Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - Support for sas_policy #19222

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Nov 10, 2022

Fix #19188

Test

💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run='TestAccStorageAccount_sasPolicy'
=== RUN   TestAccStorageAccount_sasPolicy
=== PAUSE TestAccStorageAccount_sasPolicy
=== CONT  TestAccStorageAccount_sasPolicy
--- PASS: TestAccStorageAccount_sasPolicy (199.35s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       199.361s

Type: pluginsdk.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{
// There is no definition of this enum in the Track1 SDK due to: https://github.com/Azure/azure-sdk-for-go/issues/14589
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that issue was closed as wont't fix - has it been added to the swagger or should we be opening an issue on the rest api specs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not a swagger issue, but a Track1 SDK issue. As they are not support track1 SDK, they closed that issue. This comment is to explain why there isn't an enum defined in the SDK, not meant to be a TODO. If there are more than one enum defined for that attribute in later API, then there will be enums defined in the SDK.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the swagger is correct?

also is there a reason for this to be required with a single value? we could make it optional with a default?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, swagger is correct. Good idea, will make the change then.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect thanks for checking - this'll be fine and be fixed by the pandora SDK then

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @magodo - LGTM now 🦕

Type: pluginsdk.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{
// There is no definition of this enum in the Track1 SDK due to: https://github.com/Azure/azure-sdk-for-go/issues/14589
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect thanks for checking - this'll be fine and be fixed by the pandora SDK then

@katbyte katbyte merged commit 13ac1a1 into hashicorp:main Nov 14, 2022
katbyte added a commit that referenced this pull request Nov 14, 2022
@github-actions github-actions bot added this to the v3.32.0 milestone Nov 14, 2022
@github-actions
Copy link

This functionality has been released in v3.32.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage account - SAS token expiry upper limit
2 participants